refactor: modularize navigation and extract business logic to ViewModels#30
Merged
Merged
Conversation
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
Signed-off-by: Isaac Serrano <serranoie99@gmail.com>
5669840 to
5154dea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrates detekt static analysis into CI/CD pipelines and configures it with thresholds tuned for this Android/Compose codebase.
Change strategy
Deocuple existing screens to follow proper MVI implementation and architecturing.
Implemented
config/detekt/detekt.ymlwith per-ruleset thresholds and rule-level settingsconfig/detekt/detekt-baseline.xml(empty — no pre-existing violations against tuned config)Working demo
App is running.
Testing
Notes
disableDefaultRuleSets = true): The Gradle plugin does not support aformatting:YAML key, and there is noexcludeRulesAPI. The only way to drop formatting rules is to drop all default rulesets. Formatting (indentation, line length, trailing whitespace) is cosmetic — KtLint handles it in the IDE. If you want to enforce formatting in CI, use the detekt CLI tool directly instead of the Gradle plugin.